DM-44136: Refactor OIDC tests #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add helper functions to the LDAP mock to create test users and group memberships, and use those everywhere. Remove duplicate tests and now-unused configuration files. Consolidate all of the OIDC login tests into a single test file.
The GitHub mock setup function was async for reasons that have subsequently been fixed in the config dependency, so make it sync again, since that's somewhat clearer.
The user base DN is now a mandatory setting if LDAP is enabled, so we don't have to check whether it's set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add helper functions to the LDAP mock to create test users and group memberships, and use those everywhere. Remove duplicate tests and now-unused configuration files. Consolidate all of the OIDC login tests into a single test file.