Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add casts for package metadata #99

Merged
merged 2 commits into from May 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/safir/metadata.py
Expand Up @@ -3,9 +3,10 @@

from __future__ import annotations

import sys
from email.message import Message
from importlib.metadata import metadata
from typing import Optional
from typing import Optional, cast

from pydantic import BaseModel, Field

Expand Down Expand Up @@ -66,7 +67,10 @@ def get_metadata(*, package_name: str, application_name: str) -> Metadata:
project_urls, Source code
Used as the ``respository_url``.
"""
pkg_metadata: Message = metadata(package_name)
if sys.version_info >= (3, 10):
pkg_metadata = cast(Message, metadata(package_name))
else:
pkg_metadata = metadata(package_name)
return Metadata(
name=application_name,
version=pkg_metadata.get("Version", "0.0.0"),
Expand Down
12 changes: 7 additions & 5 deletions tests/metadata_test.py
Expand Up @@ -3,20 +3,22 @@

from __future__ import annotations

import sys
from email.message import Message
from importlib.metadata import metadata
from typing import TYPE_CHECKING
from typing import cast

import pytest

from safir.metadata import get_metadata, get_project_url

if TYPE_CHECKING:
from email.message import Message


@pytest.fixture(scope="session")
def safir_metadata() -> Message:
return metadata("safir")
if sys.version_info >= (3, 10):
return cast(Message, metadata("safir"))
else:
return metadata("safir")


def test_get_project_url(safir_metadata: Message) -> None:
Expand Down