[WIP] No showDiff on assert interface chaijs#515

lucasfcosta · Dec 18, 2015 · ef9a197 · ef9a197
1 parent e1b504c
commit ef9a197
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/lib/chai/assertion.js b/lib/chai/assertion.js
@@ -98,9 +98,11 @@ module.exports = function (_chai, util) {
 
   Assertion.prototype.assert = function (expr, msg, negateMsg, expected, _actual, showDiff) {
     var ok = util.test(this, arguments);
-    if (true !== showDiff) showDiff = false;
-    if (true !== config.showDiff) showDiff = false;
+    if (false !== showDiff) showDiff = true;
+    if (undefined === expected && undefined === _actual) showDiff = false;
 
+    console.log('expected: ' + expected);
+    console.log('actual: ' + _actual);
     if (!ok) {
       var msg = util.getMessage(this, arguments)
         , actual = util.getActual(this, arguments);

diff --git a/test/assert.js b/test/assert.js
@@ -1040,4 +1040,13 @@ describe('assert', function () {
       }, 'expected undefined to not be frozen');
     });
   });
+
+  it.only('passing exp and act makes showDiff be true', function() {
+    try {
+      assert.equal('one', 'two');
+    } catch(e) {
+      console.log(e);
+      assert.isTrue(e.showDiff);
+    }
+  });
 });