Drop support for Node 12 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require Node 16 or later. (I’m open to even bumping this to Node 18 later, but I don’t think it’s needed at the moment.) Part of #25. In GitHub actions, we need to keep the split between test-full and test-most, because test:browser requires Node 18 (16 is not enough, it still doesn’t have fetch()), but we also want to test Node 16 compatibility.
Node defines the `performance` global since version 16. Part of #25. Note that this will require changes in m3api-query and m3api-oauth2, which also import this file in their tests.
Possible now that we no longer need to support Node 12. Part of #25.
Minor code changes necessary, but otherwise it seems to work well enough. Part of #25.
We no longer need --harmony-top-level-await, so we also no longer need to try running Node twice. Part of #25.
Nicer than accessing fs.promises afterwards. Part of #25.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #25.