Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): add mop #2049

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(icons): add mop #2049

wants to merge 6 commits into from

Conversation

gurtt
Copy link
Contributor

@gurtt gurtt commented Apr 5, 2024

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

A mop (wet broom).

Icon use case

  • as a literal mop
  • as an icon for cleaning

Alternative icon designs

mop-alt

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@gurtt gurtt mentioned this pull request Apr 5, 2024
23 tasks
@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

Added or changed icons

icons/mop.svg

Preview cohesion icons/message-square-text.svg
icons/mop.svg
icons/paintbrush-2.svg
Preview stroke widths icons/mop.svg
icons/mop.svg
icons/mop.svg
DPI Preview (24px) icons/mop.svg
Icon X-rays icons/mop.svg

Icons as code

Only working for:
lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const MopIcon = createLucideIcon('Mop', [
  ["path",{"d":"M12 12 22 2"}],
  ["path",{"d":"M7 22c-2.76 0-5-2.24-5-5s2.24-5 5-5c1.423 0 3.028-.594 3.69-.866a.5.5 0 0 1 .547.106c.297.294.763.76.763.76l.765.765a.5.5 0 0 1 .11.542C12.605 13.985 12 15.661 12 17q0 .514-.1 1"}],
  ["path",{"d":"M7 22h8.5c.133 0 .26-.053.354-.146A.5.5 0 0 0 16 21.5v-.012A3.49 3.49 0 0 0 12.512 18H10"}]
])

@gurtt
Copy link
Contributor Author

gurtt commented Apr 6, 2024

broom
Here's an alt design that's a broom but I don't think it's got enough of a different use case to be a separate icon.

Copy link

github-actions bot commented May 7, 2024

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant