fix(core): serialize properly override with object arg for command line

Avoid outputting object args as [object Object]. Is related to nrwl#10808
lukasalphta · Oct 27, 2022 · 83f9c3c · 83f9c3c
1 parent 0f2b89b
commit 83f9c3c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/packages/nx/src/utils/command-line-utils.spec.ts b/packages/nx/src/utils/command-line-utils.spec.ts
@@ -99,6 +99,7 @@ describe('splitArgs', () => {
         {
           files: [''],
           notNxArg: true,
+          notNxArgObject: { objectKey: 'my value' },
           __positional_overrides__: [],
           $0: '',
         },
@@ -107,8 +108,12 @@ describe('splitArgs', () => {
         {} as any
       ).overrides
     ).toEqual({
-      __overrides_unparsed__: ['--notNxArg=true'],
+      __overrides_unparsed__: [
+        '--notNxArg=true',
+        '--notNxArgObject={"objectKey":"my value"}',
+      ],
       notNxArg: true,
+      notNxArgObject: { objectKey: 'my value' },
     });
   });
 

diff --git a/packages/nx/src/utils/serialize-overrides-into-command-line.ts b/packages/nx/src/utils/serialize-overrides-into-command-line.ts
@@ -7,7 +7,9 @@ export function serializeOverridesIntoCommandLine(args: {
       r.push(
         typeof args[a] === 'string' && args[a].includes(' ')
           ? `--${a}="${args[a].replace(/"/g, '"')}"`
-          : `--${a}=${args[a]}`
+          : `--${a}=${
+              typeof args[a] === 'object' ? JSON.stringify(args[a]) : args[a]
+            }`
       );
     }
   });