v2.1.0 #12
Merged
v2.1.0 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
lukaswagner
commented
Nov 23, 2021
lukaswagner
commented
- fixes file dialogs on linux (file select breaks on linux #5)
- fixes unicode path handling (unicode not handled correctly #7)
- changes ui behaviour for export target (select dir instead of file) (export: output select should be using dir select or text input #8)
Choosing a file does not make sense, as the normal use case would require to select a nonexistent file. Also, choosing a file disables auto-naming, which is the preferred behavior.
paths are separated using null bytes, thus the regex, see https://git-scm.com/docs/git-diff#Documentation/git-diff.txt--z
closes #7: ask git to not escape unicode chars
closes #8: select a dir for export instead of file
…rror closes #5: use async file dialog to avoid electron bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.