Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add next() to express template, closes #1593 #1625

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

ericwooley
Copy link
Contributor

closes #1593

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

Put closes #XXXX (where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.

If this is a new feature submission:

  • Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project?

Potential Problems With The Approach

Technically this could be considered a breaking change, but IMO it should be considered a bug fix.

Test plan

I added an in memory boolean to the express server, added routes to check/modify that boolean, and a middleware which modifies the bool after the register routes. The tests first set that boolean to false, then, after a route has run through tsoa, checks that the boolean was modified by the middleware.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there ericwooley 👋

Thank you and congrats 🎉 for opening your first PR on this project.✨

We will review the following PR soon! 👀

@ericwooley ericwooley changed the title add next to template, closes #1593 add next() to express template, closes #1593 May 12, 2024
@ericwooley
Copy link
Contributor Author

Hi @lukeautry

Just wanted to check in and see if this got lost in the shuffle

@WoH WoH merged commit aedd603 into lukeautry:master Jun 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Middleware after response
2 participants