Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show TSLint in "Linter/Formatter" when TypeScript selected #44

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Show TSLint in "Linter/Formatter" when TypeScript selected #44

wants to merge 3 commits into from

Conversation

tatchi
Copy link

@tatchi tatchi commented Oct 2, 2018

My attempt to implement second point of #36.

As soon as "Linter/Formatter" feature is selected, all options are displayed (regardless of TypeScript selection). If TypeScript is selected but not the "Linter/Formatter", only TSLint option is proposed.

Hope that the logic is correct 馃槵

Don't hesitate if you see any improvement 馃槉

@lukeed
Copy link
Owner

lukeed commented Oct 2, 2018

Thanks @tatchi~!

I think that TSLint should only appear when Linter or Formatter feature is selected, so the logic is doing more than it should IMO.

I'll make that change for you once I get TS in completely 馃憤 Holding off on merging this until then.

馃檱

@tatchi
Copy link
Author

tatchi commented Oct 2, 2018

Thanks @lukeed :)

I still changed the logic: now it displays the options only when Linter or Formatter feature is selected. If TypeScript is selected then it shows TSLint, otherwise ESLint

Feel free to change if it's still not aligned with your expectation :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants