Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 #24

Merged
merged 35 commits into from
Jan 16, 2023
Merged

2.0 #24

merged 35 commits into from
Jan 16, 2023

Conversation

lukeed
Copy link
Owner

@lukeed lukeed commented Jan 16, 2023

Breaking change because the resolve function (as well as the new exports and imports functions) can now return string[] | undefined instead of string | undefined.

@lukeed
Copy link
Owner Author

lukeed commented Jan 16, 2023

definitely have 2 tests covering the 1 line that nyc & codecov thinks isn't being covered

@codecov-commenter
Copy link

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (23b6e2d) compared to base (dc499dc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         3    +2     
  Lines           61        84   +23     
  Branches         0        43   +43     
=========================================
+ Hits            61        84   +23     
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/legacy.ts 100.00% <100.00%> (ø)
src/utils.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lukeed lukeed merged commit e077d8b into master Jan 16, 2023
@lukeed lukeed deleted the next branch January 16, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: could exports support array Extract resolution algorithm for imports
2 participants