fix(sirv): skip req._decode
shortcuts; decode manually
#118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With lukeed/polka#175, there's no longer a
toDecode
parameter, sosirv
must do it manually.Also, through vitejs/vite#4728 discussion, relying on existing
req.path
orreq._decoded
mutations could cause issues downstream, depending on how (or how often)sirv
was invoked. To deal with this,sirv
invokes@polka/url
every request for consistency, which is fine because the parser is so fast.