Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sirv): skip req._decode shortcuts; decode manually #118

Merged
merged 1 commit into from Aug 27, 2021

Conversation

lukeed
Copy link
Owner

@lukeed lukeed commented Aug 27, 2021

With lukeed/polka#175, there's no longer a toDecode parameter, so sirv must do it manually.

Also, through vitejs/vite#4728 discussion, relying on existing req.path or req._decoded mutations could cause issues downstream, depending on how (or how often) sirv was invoked. To deal with this, sirv invokes @polka/url every request for consistency, which is fine because the parser is so fast.

@codecov-commenter
Copy link

Codecov Report

Merging #118 (4b417e1) into master (435473f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   62.23%   62.23%           
=======================================
  Files           2        2           
  Lines         143      143           
=======================================
  Hits           89       89           
  Misses         54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 435473f...4b417e1. Read the comment docs.

@lukeed lukeed merged commit a733157 into master Aug 27, 2021
@lukeed lukeed deleted the fix/no-decode-cache branch August 27, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants