Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error handling in a runner [closes #60] #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matej21
Copy link
Contributor

@matej21 matej21 commented Nov 4, 2020

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #61 into master will increase coverage by 6.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   89.89%   96.44%   +6.54%     
==========================================
  Files           3        3              
  Lines         297      309      +12     
==========================================
+ Hits          267      298      +31     
+ Misses         30       11      -19     
Impacted Files Coverage Δ
src/index.js 96.33% <100.00%> (+20.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f9dfb7...9e6aed3. Read the comment docs.

@benmccann
Copy link

@lukeed would you have a chance to review this one at some point? hope you are having happy holidays!

@lukeed
Copy link
Owner

lukeed commented Dec 28, 2020

Yes, after the holiday :) definitely did not forget about this.

Thanks, I hope you (both) are too~!

@matthewp
Copy link

Hey @lukeed, I hate to bother, is there a chance this PR can be reviewed? Loving uvu 🙌

@lukeed
Copy link
Owner

lukeed commented Mar 23, 2021

Hey, not a problem. Sorry (to all) for the wait! Looking to make a uvu pass this week. There were some things I wanted to tweak in this PR, which is why it's not merged as is.

Thanks for the patience :)

@Kamrulhasan12345
Copy link

Sorry to bother, but any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants