Refactor: DRY things out #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lundberg
reviewed
Sep 14, 2020
There was a problem hiding this comment.
Thanks for contributing @jocke-l .
I'm on both sides regarding this change. Your simplification is actually how the source used to look like, but were discussed in #41 and refactored in #44 😉
I agree that the code is easier to maintain like this, but autocompletion and tracing wins this time I suppose.
Your other refactoring makes sense though...keep that and I'll re-review 👍🏻
jocke-l
force-pushed
the
refactor/dry
branch
from
3603b6d
to
11474cf
Compare
jocke-l
force-pushed
the
refactor/dry
branch
from
11474cf
to
e60a676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some excessive code which in the long run hopefully will make the code base easier to maintain.