-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pxp): hookup zephyr interrupts #6158
base: release/v8.4
Are you sure you want to change the base?
Conversation
@kisvegabor Just noticed while setting up a zephyr testcase for this: In order to compile we need to provide the displays dimensions as compile time constants |
This adds attaching of the interrupt for Zephyr RTOS. Originally submitted by @0xFarahFl.
#ifndef LCD_WIDTH
#define LCD_WIDTH lv_display_get_horizontal_resolution(_lv_refr_get_disp_refreshing())
#endif Can you check if it's really working? |
I think using the methods is not really an option since I guess those need to be compile time defined: |
We should remove the PXP temp buffer. It has been removed in lvgl v9, as multiple PXP steps have been disabled. In V9 the PXP will handle only the operations that can be done in a single shot. I will speak to @cristian-stoica to remove this temp buffer on lvgl v8.4 too, it was a bad decision to add it. |
Description of the feature or fix
While adding PXP support for zephyr by adding the semaphore, adding the actual interrupts was missing. It was unclear what the best place to put this is. This adds a depedency on the Zephyr symbol
CONFIG_DMA_INIT_PRIORITY
and the IRQ API, both of which are stable. Originally proposed via: zephyrproject-rtos/lvgl#52Notes
lv_conf_template.h
run lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py
(astyle version v3.4.12 needs to be installed) and follow the Code Conventions.