Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(refr): add backward compatibility for LV_COLOR_16_SWAP #6225

Merged
merged 1 commit into from
May 24, 2024

Conversation

kisvegabor
Copy link
Member

fixes #6104

Description of the feature or fix

A clear and concise description of what the bug or new feature is.

Notes

@XuNeo
Copy link
Collaborator

XuNeo commented May 14, 2024

Thank you Gabor. Should we also add LV_COLOR_16_SWAP option to lv_conf.h and Kconfig?

Copy link
Collaborator

@PGNetHun PGNetHun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Will it remain in future too?

@kisvegabor
Copy link
Member Author

Should we also add LV_COLOR_16_SWAP option to lv_conf.h and Kconfig?

My understanding was the goals of this update is to make previous drivers and configs work with v9 too. In light of that, I wouldn't add it the config files in v9 because this way people probably will start using it again. If it's really needed the users can add it manually (or it will be picked up from the old configs) What do you think?

Thanks. Will it remain in future too?

We can leave it for a major versions. Maybe adding a #warning could be useful too.

@kisvegabor
Copy link
Member Author

Merging it now. @XuNeo let me know you think we need to do more with it.

@kisvegabor kisvegabor merged commit b8b7e29 into lvgl:master May 24, 2024
19 checks passed
@kisvegabor kisvegabor deleted the feat/color16_swap branch May 24, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add back CONFIG_LV_COLOR_16_SWAP
4 participants