Skip to content

Commit

Permalink
Try latest libxml2/libxslt in CI.
Browse files Browse the repository at this point in the history
  • Loading branch information
@scoder
scoder committed May 25, 2023
1 parent e51b4ee commit 0268b8e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Expand Up @@ -131,8 +131,8 @@ jobs:
OS_NAME: ${{ matrix.os }}
PYTHON_VERSION: ${{ matrix.python-version }}
MACOSX_DEPLOYMENT_TARGET: 11.0
LIBXML2_VERSION: 2.10.3
LIBXSLT_VERSION: 1.1.37
LIBXML2_VERSION: 2.11.4
LIBXSLT_VERSION: 1.1.38
COVERAGE: false
GCC_VERSION: 9
USE_CCACHE: 1
Expand Down

3 comments on commit 0268b8e

@rotu
Copy link
Contributor

@rotu rotu commented on 0268b8e Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you been able to get these changes to actually build?

@scoder
Copy link
Member Author

@scoder scoder commented on 0268b8e Jul 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libxml2 2.10.3 seems to work. I'll stick to it for lxml 4.9.3 since that's a point release. I'll try 2.11.x for lxml 5.0 again.
libxml2 2.10.4 is a point release, too, but includes an incompatible change in HTML parsing.

@rotu
Copy link
Contributor

@rotu rotu commented on 0268b8e Jul 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libxml2 2.10.4 is a point release, too, but includes an incompatible change in HTML parsing.

Youch - that's frustrating.

I've been trying to get this to build on python 3.12 and no luck so far. It would be good to have some idea (whether by CI results or by documentation e.g. in build.txt) what versions are in scope.

Please sign in to comment.