Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move zlib.h and friends into a subdirectory "extlibs" in lxml/include…
…s/ to separate them from lxml-version.h etc. These files are copied by setuptools as package data from an external install directory and thus need to be in a separate package to prevent conflicting with the content of the normal lxml.includes package.
- Loading branch information
Showing
2 changed files
with
11 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
745ac26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scoder thanks for the quick fix here!
I see the release here https://github.com/lxml/lxml/releases/tag/lxml-4.7.1 but it's not on pypi yet
745ac26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you maybe try one of those wheels? I changed the place where some header files are stored, so there is a slight chance that I broke something else.
745ac26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually quite tricky to pin a specific wheel when using
pip install xmlsec
I'll see what I can do745ac26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you just pass it as a second parameter on the command line? (Ok, you probably tried that…)
745ac26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xmlsec just normally calls
lxml.get_include()
in its setup.py. That adds one more include directory now, to include also the headers of zlib and iconv. I think it should still work ok.745ac26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've started uploading the release.