Fix crash due to order of initialization for threading on Windows with shared libxml2 2.11.4 #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an Access Violation on Windows when using a shared build of libxml2 2.11.4. Stacktrace: ntdll.dll!RtlpWaitOnCriticalSection() + 0xa6 Bytes ntdll.dll!RtlpEnterCriticalSectionContended() + 0x1c4 Bytes ntdll.dll!RtlEnterCriticalSection() + 0x42 Bytes > libxml2.dll!xmlRMutexLock(_xmlRMutex * tok=0x0000000002fea170) Zeile 234 C libxml2.dll!xmlThrDefIndentTreeOutput(int v=0) Zeile 934 C etree.pyd!00000000037fc566() python27.dll!_PyImport_LoadDynamicModule(char * name=0x0000000002fe4408, char * pathname=0x000000005a49c660, _iobuf * fp=0x0000000002839880) Zeile 54 C libxml2 changed the mutex initialization in this commit: https://gitlab.gnome.org/GNOME/libxml2/-/commit/65d381f32c0d2cb2361055fddbd5c4a9119031d1 xmlThrDefIndentTreeOutput tries to use the global Mutex, but this is only initialized by xmlInitParser(), so it crashes due to wrong initialization order.
schlenk
changed the title
|
Looks reasonable, thanks. I'll see what CI says and then merge it. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an Access Violation on Windows when using a shared build of libxml2 2.11.4.
Stacktrace:
libxml2 changed the mutex initialization in this commit: https://gitlab.gnome.org/GNOME/libxml2/-/commit/65d381f32c0d2cb2361055fddbd5c4a9119031d1
xmlThrDefIndentTreeOutput tries to use the global Mutex, but this is only initialized by xmlInitParser(), so it crashes due to wrong initialization order.