Allow paths in name entry of file dialog #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A path can be absolute or relative and can be used with file opening and saving alike. Also, two minor issues are revealed and fixed after this change: * A mistake is corrected in the logic of showing error message about nonexistent files. * An issue is fixed in updating accept button on changing directory. NOTE: Although this isn't self-consistent, Qt's default file dialog supports it. It can also be useful when the path is already copied from somewhere. The extra code is kept to a minimum. Closes #962
tsujan
force-pushed
the
filedialog_filepath
branch
from
c4c1beb
to
0e49a72
Compare
|
@stefonarch |
|
I've used it some time now, didn't notice issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A path can be absolute or relative and can be used with file opening and saving alike.
Also, two minor issues are revealed and fixed after this change:
NOTE: Although this isn't self-consistent, Qt's default file dialog supports it. It can also be useful when the path is already copied from somewhere. The extra code is kept to a minimum.
Closes #962