Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add *.rst glob pattern to defaults #197

Merged
merged 2 commits into from
Jun 11, 2023
Merged

Add *.rst glob pattern to defaults #197

merged 2 commits into from
Jun 11, 2023

Conversation

kdeldycke
Copy link
Contributor

Lychee is advertising its capability of checking reStructuredText files, so I guess it is a good idea to add these files to the default glob pattern.

@mre
Copy link
Member

mre commented Jun 11, 2023

Hey Kevin, great idea!

Code looks good.
Could you also add an example fixtures/TEST.rst file with some links and add a test like this? (Ideally, we'd want to check the links it found in the tests as well, but at the moment we only test the lychee invocation.)

@kdeldycke
Copy link
Contributor Author

Could you also add an example fixtures/TEST.rst file with some links and add a test like this? (Ideally, we'd want to check the links it found in the tests as well, but at the moment we only test the lychee invocation.)

Done!

Is that good to you? Can you approve the workflow run on that PR so we can check everything's fine?

@mre
Copy link
Member

mre commented Jun 11, 2023

You got it.

@mre mre merged commit 0c01f23 into lycheeverse:master Jun 11, 2023
3 checks passed
@kdeldycke
Copy link
Contributor Author

Thanks @mre for the fast merge and feedback!

@kdeldycke kdeldycke deleted the check-rst branch June 11, 2023 16:08
renovate bot added a commit to mykso/myks that referenced this pull request Jan 5, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[lycheeverse/lychee-action](https://togithub.com/lycheeverse/lychee-action)
| action | minor | `v1.8.0` -> `v1.9.0` |

---

### Release Notes

<details>
<summary>lycheeverse/lychee-action (lycheeverse/lychee-action)</summary>

###
[`v1.9.0`](https://togithub.com/lycheeverse/lychee-action/releases/tag/v1.9.0):
Version 1.9.0

[Compare
Source](https://togithub.com/lycheeverse/lychee-action/compare/v1.8.0...v1.9.0)

#### What's Changed

- Document the current directory for the cache argument example by
[@&#8203;theredfish](https://togithub.com/theredfish) in
[lycheeverse/lychee-action#193
- Add `*.rst` glob pattern to defaults by
[@&#8203;kdeldycke](https://togithub.com/kdeldycke) in
[lycheeverse/lychee-action#197
- Automatically pass Github token by
[@&#8203;mre](https://togithub.com/mre) in
[lycheeverse/lychee-action#196
- Always create output file; not only on error by
[@&#8203;mre](https://togithub.com/mre) in
[lycheeverse/lychee-action#199
- Bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[lycheeverse/lychee-action#208
- add documentation on using the param when testing local files (as in…
by [@&#8203;tgaff](https://togithub.com/tgaff) in
[lycheeverse/lychee-action#211
- fix: Lychee output to file (fixes
[#&#8203;214](https://togithub.com/lycheeverse/lychee-action/issues/214))
by [@&#8203;LilDrunkenSmurf](https://togithub.com/LilDrunkenSmurf) in
[lycheeverse/lychee-action#215
- Add integration test for custom output paths
([#&#8203;215](https://togithub.com/lycheeverse/lychee-action/issues/215))
by [@&#8203;mre](https://togithub.com/mre) in
[lycheeverse/lychee-action#217
- Add integration tests for absolute output path and `--dump` by
[@&#8203;mre](https://togithub.com/mre) in
[lycheeverse/lychee-action#218

#### New Contributors

- [@&#8203;theredfish](https://togithub.com/theredfish) made their first
contribution in
[lycheeverse/lychee-action#193
- [@&#8203;kdeldycke](https://togithub.com/kdeldycke) made their first
contribution in
[lycheeverse/lychee-action#197
- [@&#8203;tgaff](https://togithub.com/tgaff) made their first
contribution in
[lycheeverse/lychee-action#211
- [@&#8203;LilDrunkenSmurf](https://togithub.com/LilDrunkenSmurf) made
their first contribution in
[lycheeverse/lychee-action#215

**Full Changelog**:
lycheeverse/lychee-action@v1...v1.9.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log [here](https://developer.mend.io/github/mykso/myks).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2In0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to Unleash/unleash that referenced this pull request Jan 12, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change | Pending |
|---|---|---|---|---|
|
[lycheeverse/lychee-action](https://togithub.com/lycheeverse/lychee-action)
| action | minor | `v1.8.0` -> `v1.9.0` | `v1.9.1` |

---

### Release Notes

<details>
<summary>lycheeverse/lychee-action (lycheeverse/lychee-action)</summary>

###
[`v1.9.0`](https://togithub.com/lycheeverse/lychee-action/releases/tag/v1.9.0):
Version 1.9.0

[Compare
Source](https://togithub.com/lycheeverse/lychee-action/compare/v1.8.0...v1.9.0)

#### What's Changed

- Document the current directory for the cache argument example by
[@&#8203;theredfish](https://togithub.com/theredfish) in
[lycheeverse/lychee-action#193
- Add `*.rst` glob pattern to defaults by
[@&#8203;kdeldycke](https://togithub.com/kdeldycke) in
[lycheeverse/lychee-action#197
- Automatically pass Github token by
[@&#8203;mre](https://togithub.com/mre) in
[lycheeverse/lychee-action#196
- Always create output file; not only on error by
[@&#8203;mre](https://togithub.com/mre) in
[lycheeverse/lychee-action#199
- Bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[lycheeverse/lychee-action#208
- add documentation on using the param when testing local files (as in…
by [@&#8203;tgaff](https://togithub.com/tgaff) in
[lycheeverse/lychee-action#211
- fix: Lychee output to file (fixes
[#&#8203;214](https://togithub.com/lycheeverse/lychee-action/issues/214))
by [@&#8203;LilDrunkenSmurf](https://togithub.com/LilDrunkenSmurf) in
[lycheeverse/lychee-action#215
- Add integration test for custom output paths
([#&#8203;215](https://togithub.com/lycheeverse/lychee-action/issues/215))
by [@&#8203;mre](https://togithub.com/mre) in
[lycheeverse/lychee-action#217
- Add integration tests for absolute output path and `--dump` by
[@&#8203;mre](https://togithub.com/mre) in
[lycheeverse/lychee-action#218

#### New Contributors

- [@&#8203;theredfish](https://togithub.com/theredfish) made their first
contribution in
[lycheeverse/lychee-action#193
- [@&#8203;kdeldycke](https://togithub.com/kdeldycke) made their first
contribution in
[lycheeverse/lychee-action#197
- [@&#8203;tgaff](https://togithub.com/tgaff) made their first
contribution in
[lycheeverse/lychee-action#211
- [@&#8203;LilDrunkenSmurf](https://togithub.com/LilDrunkenSmurf) made
their first contribution in
[lycheeverse/lychee-action#215

**Full Changelog**:
lycheeverse/lychee-action@v1...v1.9.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 7pm every weekday,before 5am
every weekday" in timezone Europe/Madrid, Automerge - At any time (no
schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Unleash/unleash).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants