-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add documentation on using the param when testing local files (as in… #211
Conversation
That looks correct. You understood correctly. I agree that we should add the parameter to the other examples. Can you do that? Also, what do you think about moving the Also, the integration tests in the |
done
I've added a test, but it looks like a maintainer will have to approve running them. |
I've done this for every example that already included args. I could do it for all examples, but I'll have to add full (default) args for each. What do you think? |
Co-authored-by: Chip Zoller <chipzoller@gmail.com>
Co-authored-by: Chip Zoller <chipzoller@gmail.com>
Co-authored-by: Mehdi <9340937+meduzen@users.noreply.github.com>
Apologies for the delays. Looks good, so I finally merged it. 😊 |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [lycheeverse/lychee-action](https://togithub.com/lycheeverse/lychee-action) | action | minor | `v1.8.0` -> `v1.9.0` | --- ### Release Notes <details> <summary>lycheeverse/lychee-action (lycheeverse/lychee-action)</summary> ### [`v1.9.0`](https://togithub.com/lycheeverse/lychee-action/releases/tag/v1.9.0): Version 1.9.0 [Compare Source](https://togithub.com/lycheeverse/lychee-action/compare/v1.8.0...v1.9.0) #### What's Changed - Document the current directory for the cache argument example by [@​theredfish](https://togithub.com/theredfish) in [lycheeverse/lychee-action#193 - Add `*.rst` glob pattern to defaults by [@​kdeldycke](https://togithub.com/kdeldycke) in [lycheeverse/lychee-action#197 - Automatically pass Github token by [@​mre](https://togithub.com/mre) in [lycheeverse/lychee-action#196 - Always create output file; not only on error by [@​mre](https://togithub.com/mre) in [lycheeverse/lychee-action#199 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [lycheeverse/lychee-action#208 - add documentation on using the param when testing local files (as in… by [@​tgaff](https://togithub.com/tgaff) in [lycheeverse/lychee-action#211 - fix: Lychee output to file (fixes [#​214](https://togithub.com/lycheeverse/lychee-action/issues/214)) by [@​LilDrunkenSmurf](https://togithub.com/LilDrunkenSmurf) in [lycheeverse/lychee-action#215 - Add integration test for custom output paths ([#​215](https://togithub.com/lycheeverse/lychee-action/issues/215)) by [@​mre](https://togithub.com/mre) in [lycheeverse/lychee-action#217 - Add integration tests for absolute output path and `--dump` by [@​mre](https://togithub.com/mre) in [lycheeverse/lychee-action#218 #### New Contributors - [@​theredfish](https://togithub.com/theredfish) made their first contribution in [lycheeverse/lychee-action#193 - [@​kdeldycke](https://togithub.com/kdeldycke) made their first contribution in [lycheeverse/lychee-action#197 - [@​tgaff](https://togithub.com/tgaff) made their first contribution in [lycheeverse/lychee-action#211 - [@​LilDrunkenSmurf](https://togithub.com/LilDrunkenSmurf) made their first contribution in [lycheeverse/lychee-action#215 **Full Changelog**: lycheeverse/lychee-action@v1...v1.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/mykso/myks). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2In0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [lycheeverse/lychee-action](https://togithub.com/lycheeverse/lychee-action) | action | minor | `v1.8.0` -> `v1.9.0` | `v1.9.1` | --- ### Release Notes <details> <summary>lycheeverse/lychee-action (lycheeverse/lychee-action)</summary> ### [`v1.9.0`](https://togithub.com/lycheeverse/lychee-action/releases/tag/v1.9.0): Version 1.9.0 [Compare Source](https://togithub.com/lycheeverse/lychee-action/compare/v1.8.0...v1.9.0) #### What's Changed - Document the current directory for the cache argument example by [@​theredfish](https://togithub.com/theredfish) in [lycheeverse/lychee-action#193 - Add `*.rst` glob pattern to defaults by [@​kdeldycke](https://togithub.com/kdeldycke) in [lycheeverse/lychee-action#197 - Automatically pass Github token by [@​mre](https://togithub.com/mre) in [lycheeverse/lychee-action#196 - Always create output file; not only on error by [@​mre](https://togithub.com/mre) in [lycheeverse/lychee-action#199 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [lycheeverse/lychee-action#208 - add documentation on using the param when testing local files (as in… by [@​tgaff](https://togithub.com/tgaff) in [lycheeverse/lychee-action#211 - fix: Lychee output to file (fixes [#​214](https://togithub.com/lycheeverse/lychee-action/issues/214)) by [@​LilDrunkenSmurf](https://togithub.com/LilDrunkenSmurf) in [lycheeverse/lychee-action#215 - Add integration test for custom output paths ([#​215](https://togithub.com/lycheeverse/lychee-action/issues/215)) by [@​mre](https://togithub.com/mre) in [lycheeverse/lychee-action#217 - Add integration tests for absolute output path and `--dump` by [@​mre](https://togithub.com/mre) in [lycheeverse/lychee-action#218 #### New Contributors - [@​theredfish](https://togithub.com/theredfish) made their first contribution in [lycheeverse/lychee-action#193 - [@​kdeldycke](https://togithub.com/kdeldycke) made their first contribution in [lycheeverse/lychee-action#197 - [@​tgaff](https://togithub.com/tgaff) made their first contribution in [lycheeverse/lychee-action#211 - [@​LilDrunkenSmurf](https://togithub.com/LilDrunkenSmurf) made their first contribution in [lycheeverse/lychee-action#215 **Full Changelog**: lycheeverse/lychee-action@v1...v1.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 7pm every weekday,before 5am every weekday" in timezone Europe/Madrid, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Per Issue 1265 in Lychee): Add documentation about needing to apply the
--base .
parameter when testing on the file-system vs. a hosted site.I actually think this should apply to both suggested action definitions in this repo since they both test without a domain and are therefore testing on the filesystem. Neither one specifies a domain or even a localhost address.
Should I also add one that demonstrates testing against a hosted site? I imagine that was the original intent of the cron job variant.
@mre I think there's a reasonable chance I've misunderstood this behavior and your comments in 1265 - please let me know.