Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation on using the param when testing local files (as in… #211

Merged
merged 9 commits into from
Nov 30, 2023

Conversation

tgaff
Copy link
Contributor

@tgaff tgaff commented Oct 20, 2023

Per Issue 1265 in Lychee): Add documentation about needing to apply the --base . parameter when testing on the file-system vs. a hosted site.

I actually think this should apply to both suggested action definitions in this repo since they both test without a domain and are therefore testing on the filesystem. Neither one specifies a domain or even a localhost address.

Should I also add one that demonstrates testing against a hosted site? I imagine that was the original intent of the cron job variant.

@mre I think there's a reasonable chance I've misunderstood this behavior and your comments in 1265 - please let me know.

@mre
Copy link
Member

mre commented Oct 20, 2023

That looks correct. You understood correctly.

I agree that we should add the parameter to the other examples. Can you do that? Also, what do you think about moving the --base parameter to the beginning? This way, if a user adds more path arguments, they are grouped together at the end.

Also, the integration tests in the .github/workflows folder need to be adjusted.

@tgaff
Copy link
Contributor Author

tgaff commented Oct 24, 2023

moving the --base parameter to the beginning

done

the integration tests in the .github/workflows folder need to be adjusted.

I've added a test, but it looks like a maintainer will have to approve running them.

@tgaff
Copy link
Contributor Author

tgaff commented Oct 24, 2023

I agree that we should add the parameter to the other examples. Can you do that?

I've done this for every example that already included args. I could do it for all examples, but I'll have to add full (default) args for each. What do you think?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
mre and others added 2 commits November 10, 2023 15:38
Co-authored-by: Chip Zoller <chipzoller@gmail.com>
Co-authored-by: Chip Zoller <chipzoller@gmail.com>
README.md Outdated Show resolved Hide resolved
tgaff and others added 3 commits November 21, 2023 09:06
Co-authored-by: Mehdi <9340937+meduzen@users.noreply.github.com>
@mre mre merged commit ef8c8f3 into lycheeverse:master Nov 30, 2023
3 checks passed
@mre
Copy link
Member

mre commented Nov 30, 2023

Apologies for the delays. Looks good, so I finally merged it. 😊

@tgaff tgaff deleted the tgaff/all-links--base branch December 5, 2023 07:16
renovate bot added a commit to mykso/myks that referenced this pull request Jan 5, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[lycheeverse/lychee-action](https://togithub.com/lycheeverse/lychee-action)
| action | minor | `v1.8.0` -> `v1.9.0` |

---

### Release Notes

<details>
<summary>lycheeverse/lychee-action (lycheeverse/lychee-action)</summary>

###
[`v1.9.0`](https://togithub.com/lycheeverse/lychee-action/releases/tag/v1.9.0):
Version 1.9.0

[Compare
Source](https://togithub.com/lycheeverse/lychee-action/compare/v1.8.0...v1.9.0)

#### What's Changed

- Document the current directory for the cache argument example by
[@&#8203;theredfish](https://togithub.com/theredfish) in
[lycheeverse/lychee-action#193
- Add `*.rst` glob pattern to defaults by
[@&#8203;kdeldycke](https://togithub.com/kdeldycke) in
[lycheeverse/lychee-action#197
- Automatically pass Github token by
[@&#8203;mre](https://togithub.com/mre) in
[lycheeverse/lychee-action#196
- Always create output file; not only on error by
[@&#8203;mre](https://togithub.com/mre) in
[lycheeverse/lychee-action#199
- Bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[lycheeverse/lychee-action#208
- add documentation on using the param when testing local files (as in…
by [@&#8203;tgaff](https://togithub.com/tgaff) in
[lycheeverse/lychee-action#211
- fix: Lychee output to file (fixes
[#&#8203;214](https://togithub.com/lycheeverse/lychee-action/issues/214))
by [@&#8203;LilDrunkenSmurf](https://togithub.com/LilDrunkenSmurf) in
[lycheeverse/lychee-action#215
- Add integration test for custom output paths
([#&#8203;215](https://togithub.com/lycheeverse/lychee-action/issues/215))
by [@&#8203;mre](https://togithub.com/mre) in
[lycheeverse/lychee-action#217
- Add integration tests for absolute output path and `--dump` by
[@&#8203;mre](https://togithub.com/mre) in
[lycheeverse/lychee-action#218

#### New Contributors

- [@&#8203;theredfish](https://togithub.com/theredfish) made their first
contribution in
[lycheeverse/lychee-action#193
- [@&#8203;kdeldycke](https://togithub.com/kdeldycke) made their first
contribution in
[lycheeverse/lychee-action#197
- [@&#8203;tgaff](https://togithub.com/tgaff) made their first
contribution in
[lycheeverse/lychee-action#211
- [@&#8203;LilDrunkenSmurf](https://togithub.com/LilDrunkenSmurf) made
their first contribution in
[lycheeverse/lychee-action#215

**Full Changelog**:
lycheeverse/lychee-action@v1...v1.9.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log [here](https://developer.mend.io/github/mykso/myks).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2In0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to Unleash/unleash that referenced this pull request Jan 12, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change | Pending |
|---|---|---|---|---|
|
[lycheeverse/lychee-action](https://togithub.com/lycheeverse/lychee-action)
| action | minor | `v1.8.0` -> `v1.9.0` | `v1.9.1` |

---

### Release Notes

<details>
<summary>lycheeverse/lychee-action (lycheeverse/lychee-action)</summary>

###
[`v1.9.0`](https://togithub.com/lycheeverse/lychee-action/releases/tag/v1.9.0):
Version 1.9.0

[Compare
Source](https://togithub.com/lycheeverse/lychee-action/compare/v1.8.0...v1.9.0)

#### What's Changed

- Document the current directory for the cache argument example by
[@&#8203;theredfish](https://togithub.com/theredfish) in
[lycheeverse/lychee-action#193
- Add `*.rst` glob pattern to defaults by
[@&#8203;kdeldycke](https://togithub.com/kdeldycke) in
[lycheeverse/lychee-action#197
- Automatically pass Github token by
[@&#8203;mre](https://togithub.com/mre) in
[lycheeverse/lychee-action#196
- Always create output file; not only on error by
[@&#8203;mre](https://togithub.com/mre) in
[lycheeverse/lychee-action#199
- Bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[lycheeverse/lychee-action#208
- add documentation on using the param when testing local files (as in…
by [@&#8203;tgaff](https://togithub.com/tgaff) in
[lycheeverse/lychee-action#211
- fix: Lychee output to file (fixes
[#&#8203;214](https://togithub.com/lycheeverse/lychee-action/issues/214))
by [@&#8203;LilDrunkenSmurf](https://togithub.com/LilDrunkenSmurf) in
[lycheeverse/lychee-action#215
- Add integration test for custom output paths
([#&#8203;215](https://togithub.com/lycheeverse/lychee-action/issues/215))
by [@&#8203;mre](https://togithub.com/mre) in
[lycheeverse/lychee-action#217
- Add integration tests for absolute output path and `--dump` by
[@&#8203;mre](https://togithub.com/mre) in
[lycheeverse/lychee-action#218

#### New Contributors

- [@&#8203;theredfish](https://togithub.com/theredfish) made their first
contribution in
[lycheeverse/lychee-action#193
- [@&#8203;kdeldycke](https://togithub.com/kdeldycke) made their first
contribution in
[lycheeverse/lychee-action#197
- [@&#8203;tgaff](https://togithub.com/tgaff) made their first
contribution in
[lycheeverse/lychee-action#211
- [@&#8203;LilDrunkenSmurf](https://togithub.com/LilDrunkenSmurf) made
their first contribution in
[lycheeverse/lychee-action#215

**Full Changelog**:
lycheeverse/lychee-action@v1...v1.9.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 7pm every weekday,before 5am
every weekday" in timezone Europe/Madrid, Automerge - At any time (no
schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Unleash/unleash).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants