fix: Lychee output to file (fixes #214) #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Did you test it already on a fork? |
|
I have not tested it, unfortunately. I haven't found the time yet, sorry. |
|
This should then also address #216. |
|
I'm going to follow up with I'm not 100% sure how to test a forked GHA. |
|
@LilDrunkenSmurf You should be able to run the new version with output/print commands in an action targeting your branch with the changes. |
|
Thanks for the contribution. I merged the changes and they should be live in |
|
I plan to do a release of the action very soon. Then we should also have the fix with a proper release version. |
This was referenced Jan 5, 2024
Closed
renovate bot
added a commit
to mykso/myks
that referenced
this pull request
Jan 5, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [lycheeverse/lychee-action](https://togithub.com/lycheeverse/lychee-action) | action | minor | `v1.8.0` -> `v1.9.0` | --- ### Release Notes <details> <summary>lycheeverse/lychee-action (lycheeverse/lychee-action)</summary> ### [`v1.9.0`](https://togithub.com/lycheeverse/lychee-action/releases/tag/v1.9.0): Version 1.9.0 [Compare Source](https://togithub.com/lycheeverse/lychee-action/compare/v1.8.0...v1.9.0) #### What's Changed - Document the current directory for the cache argument example by [@​theredfish](https://togithub.com/theredfish) in [lycheeverse/lychee-action#193 - Add `*.rst` glob pattern to defaults by [@​kdeldycke](https://togithub.com/kdeldycke) in [lycheeverse/lychee-action#197 - Automatically pass Github token by [@​mre](https://togithub.com/mre) in [lycheeverse/lychee-action#196 - Always create output file; not only on error by [@​mre](https://togithub.com/mre) in [lycheeverse/lychee-action#199 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [lycheeverse/lychee-action#208 - add documentation on using the param when testing local files (as in… by [@​tgaff](https://togithub.com/tgaff) in [lycheeverse/lychee-action#211 - fix: Lychee output to file (fixes [#​214](https://togithub.com/lycheeverse/lychee-action/issues/214)) by [@​LilDrunkenSmurf](https://togithub.com/LilDrunkenSmurf) in [lycheeverse/lychee-action#215 - Add integration test for custom output paths ([#​215](https://togithub.com/lycheeverse/lychee-action/issues/215)) by [@​mre](https://togithub.com/mre) in [lycheeverse/lychee-action#217 - Add integration tests for absolute output path and `--dump` by [@​mre](https://togithub.com/mre) in [lycheeverse/lychee-action#218 #### New Contributors - [@​theredfish](https://togithub.com/theredfish) made their first contribution in [lycheeverse/lychee-action#193 - [@​kdeldycke](https://togithub.com/kdeldycke) made their first contribution in [lycheeverse/lychee-action#197 - [@​tgaff](https://togithub.com/tgaff) made their first contribution in [lycheeverse/lychee-action#211 - [@​LilDrunkenSmurf](https://togithub.com/LilDrunkenSmurf) made their first contribution in [lycheeverse/lychee-action#215 **Full Changelog**: lycheeverse/lychee-action@v1...v1.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/mykso/myks). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2In0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
renovate bot
added a commit
to Unleash/unleash
that referenced
this pull request
Jan 12, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [lycheeverse/lychee-action](https://togithub.com/lycheeverse/lychee-action) | action | minor | `v1.8.0` -> `v1.9.0` | `v1.9.1` | --- ### Release Notes <details> <summary>lycheeverse/lychee-action (lycheeverse/lychee-action)</summary> ### [`v1.9.0`](https://togithub.com/lycheeverse/lychee-action/releases/tag/v1.9.0): Version 1.9.0 [Compare Source](https://togithub.com/lycheeverse/lychee-action/compare/v1.8.0...v1.9.0) #### What's Changed - Document the current directory for the cache argument example by [@​theredfish](https://togithub.com/theredfish) in [lycheeverse/lychee-action#193 - Add `*.rst` glob pattern to defaults by [@​kdeldycke](https://togithub.com/kdeldycke) in [lycheeverse/lychee-action#197 - Automatically pass Github token by [@​mre](https://togithub.com/mre) in [lycheeverse/lychee-action#196 - Always create output file; not only on error by [@​mre](https://togithub.com/mre) in [lycheeverse/lychee-action#199 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [lycheeverse/lychee-action#208 - add documentation on using the param when testing local files (as in… by [@​tgaff](https://togithub.com/tgaff) in [lycheeverse/lychee-action#211 - fix: Lychee output to file (fixes [#​214](https://togithub.com/lycheeverse/lychee-action/issues/214)) by [@​LilDrunkenSmurf](https://togithub.com/LilDrunkenSmurf) in [lycheeverse/lychee-action#215 - Add integration test for custom output paths ([#​215](https://togithub.com/lycheeverse/lychee-action/issues/215)) by [@​mre](https://togithub.com/mre) in [lycheeverse/lychee-action#217 - Add integration tests for absolute output path and `--dump` by [@​mre](https://togithub.com/mre) in [lycheeverse/lychee-action#218 #### New Contributors - [@​theredfish](https://togithub.com/theredfish) made their first contribution in [lycheeverse/lychee-action#193 - [@​kdeldycke](https://togithub.com/kdeldycke) made their first contribution in [lycheeverse/lychee-action#197 - [@​tgaff](https://togithub.com/tgaff) made their first contribution in [lycheeverse/lychee-action#211 - [@​LilDrunkenSmurf](https://togithub.com/LilDrunkenSmurf) made their first contribution in [lycheeverse/lychee-action#215 **Full Changelog**: lycheeverse/lychee-action@v1...v1.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 7pm every weekday,before 5am every weekday" in timezone Europe/Madrid, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it evaluates the first
if [ ! -f "${LYCHEE_TMP}" ]; then, however it skips the second one that's essentially the same check.This combines them into a single if/else statement so it should start being evaluated.
Fixes #214