Remove inaccurate details in compact view #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mre
commented
Jun 1, 2023
| let mut errors = HashMap::new(); | ||
| errors.insert( | ||
| "HTTP", | ||
| stats.errors - stats.redirects - stats.timeouts - stats.unknown, |
There was a problem hiding this comment.
That's the reason for the bug. Redirects, timeouts, and unknown link statuses aren't counted as errors, but we still substract them from the total number of errors to calculate the HTTP errors. We might also just remove the HTTP errors in the output, but the counts of all individual "errors" would not sum up to the total error count and be even more confusing to the user. Safer to remove that than show inaccurate information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error details in the compact report are computed incorrectly.
This leads to weird output, as shown in the screenshot.
Since the information is misleading, and we show a list of errors anyway, the safest way to fix this bug is to get rid of the detailed stats.