Log redirects in verbose mode (-vv) #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a custom redirect policy, which logs redirects as debug messages. It can help with troubleshooting, e.g. in situations like #1115
mre
commented
Jun 23, 2023
| @@ -907,7 +918,7 @@ mod tests { | |||
| .await; | |||
|
|
|||
| let client = ClientBuilder::builder() | |||
| .max_redirects(1_usize) | |||
| .max_redirects(0_usize) | |||
There was a problem hiding this comment.
Actually, I think the redirect handling was incorrect before. If I set --max-redirects to 0, I expect exactly zero redirects. If I get a redirect, I would count that as an error. I don't know if that's a bug in the default reqwest retry policy handling, or if it's just my misunderstanding of how the algorithm should work.
Code is here: https://docs.rs/reqwest/latest/src/reqwest/redirect.rs.html#131 and it looks fine. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a custom redirect policy,
which logs redirects as debug messages.
It can help with troubleshooting, e.g. in situations like #1115.
@oupala fyi