Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check Twitter URLs #1147

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Don't check Twitter URLs #1147

merged 1 commit into from
Jul 13, 2023

Conversation

mre
Copy link
Member

@mre mre commented Jul 9, 2023

Twitter completely locked down and requires
a login to read tweets. (Temporarily) disable all
Twitter URLs to avoid false-positives.

For context:
zedeus/nitter#919
https://news.ycombinator.com/item?id=36540957
https://techcrunch.com/2023/06/30/twitter-now-requires-an-account-to-view-tweets/

Fixes #1108

Twitter completely locked down and requires
a login to read tweets. (Temporarily) disable all
Twitter URLs to avoid false-positives.

For context:
zedeus/nitter#919
https://news.ycombinator.com/item?id=36540957
https://techcrunch.com/2023/06/30/twitter-now-requires-an-account-to-view-tweets/

Fixes #1108
@mre mre merged commit 40ba187 into master Jul 13, 2023
5 of 6 checks passed
@mre mre deleted the twitter branch July 13, 2023 15:32
@szepeviktor
Copy link
Contributor

What cookies should one add to headers = [] to get content from Twitter?

@szepeviktor
Copy link
Contributor

Surprising fact: twitter.com responds with 200 OK for a non-existent Tweet!

@mre
Copy link
Member Author

mre commented Aug 20, 2023

What cookies should one add to headers = [] to get content from Twitter?

I honestly never tried. I can see a few cookies in my Firefox storage tab inside the browser tools. Stuff like auth_multi and auth_token and twid. I would probably start with these. 🤷‍♀️

@mre
Copy link
Member Author

mre commented Aug 20, 2023

Surprising fact: twitter.com responds with 200 OK for a non-existent Tweet!

Oh yeah, it's completely unpredictable what you might get at times. It leads to so many false-positives that it will be completely disabled by default in the next release.

@mre mre added the enhancement New feature or request label Aug 24, 2023
kdeldycke added a commit to kdeldycke/workflows that referenced this pull request Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twitter link sharing URL check returns 404
2 participants