-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check fragments in HTML files #1198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice. Especially the refactoring in fragment_checker
.
I've added some comments.
Are you planning to add support in html5ever
as well?
What would be the benefit of doing this? |
The main advantage would be feature-parity with html5gum. Then again, we wanted to remove html5ever anyway at some point and it shouldn't be a blocker. Just checking if the PR is done and ready for review. |
Ah cool, yeah I hadn't created a html5ever version because it looked like html5ever was being depreciated (and it routing the html5ever option into the file checker seemed like additional unnecessary work). |
At long last, I finally came around to reviewing and merging this. Apologies for the delay. The feature turned out great! Thanks for the contribution (and your patience) @HU90m. 🤩 |
No apology needed. Thanks for making it so easy to contribute! |
Part of the #185 work.
This PR adds fragment checking for the second type of link in #185 (comment) .