Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expand serde deserialize impl #1345

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

Techassi
Copy link
Contributor

@Techassi Techassi commented Jan 9, 2024

Fixes #1338

The config now supports a list of integers and a single integer as the accept value.

@Techassi
Copy link
Contributor Author

Techassi commented Jan 9, 2024

Seems like the lychee::cli::test_suggests_url_alternatives test is flaky again.

@mre
Copy link
Member

mre commented Jan 9, 2024

Awesome PR. Lifesaver!

Yup, sorry about that. That happens when archive.org takes too long to send a response. We have exponential back off in place, but it might be better to disable the test altogether. 😕
I re-ran it and now the error seems to be relevant to the changes. Can you take a look?

@Techassi
Copy link
Contributor Author

Techassi commented Jan 9, 2024

I re-ran it and now the error seems to be relevant to the changes. Can you take a look?

Yes, will do.

@Techassi
Copy link
Contributor Author

Techassi commented Jan 9, 2024

The test ran fine multiple times on my local machine. The description states that it is flaky:

Unfortunately, LinkedIn does not always return 999, so this is a flaky test. We only check that the cache file doesn't contain any invalid status codes.

@mre
Copy link
Member

mre commented Jan 9, 2024

LinkedIn never fails to deliver. 😆 Merging. Thanks for the quick fix!🥇

@mre mre merged commit 1ab05ef into lycheeverse:master Jan 9, 2024
6 of 7 checks passed
@Techassi
Copy link
Contributor Author

Techassi commented Jan 9, 2024

LinkedIn never fails to deliver.

Lol!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot load configuration file: invalid type: integer 200, expected a string
2 participants