Fix #1108: Make GraphJob check only for missing params #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1108.
GraphJob.from_node_schema()to check only for missing params instead of for an exact match. This is because other modules use the parameters dict to pass around extra data, so we should only be throwing an error if the GraphJob does not have what it needs.AWS_IDfor the sub resource matcher.Background
cartography intel modules often add a key to the
common_job_parametersdict that is used to specify a sub resource ID -- exampleAWS_IDfor an AWS account andOKTA_ORG_IDfor an Okta organization. We should use this key name for sub resource TargetNodeMatchers during node creation so that autocleanup can properly happen.