Update media-suite_compile.sh #2221
Conversation
VMAF support Add VMAF support to aomedia so that command --tune=vmaf can be used during encoding Please note that the default VMAF model (“/usr/local/share/model/vmaf_v0.6.1.json”) will be used unless you set the following flag when running the encoder: --vmaf-model-path=path/to/model
|
Can you confirm that the issues mentioned in #1535 does not appear anymore? |
I have successfully built with commit I pull requested only after a successful build & testing aomenc with "--tune" flag. The issue #1535 is very old .....do you mean it still persists? OR is it appearing again with my pull request in other license or settings?? The issue may be arising due to passing |
This one as I previously tried enabling vmaf for aom, but when aom was linked to ffmpeg, it failed at link time. I don't remember if I managed to get it fixed or not I do see a commit for it that came after the issue, but I don't remember testing it afterwards m-ab-s/aom@0d36ee3 |
| @@ -1019,7 +1019,7 @@ if { [[ $aom = y ]] || [[ $libavif = y ]] || { [[ $ffmpeg != no ]] && enabled li | |||
| do_uninstall include/aom "${_check[@]}" | |||
| get_external_opts extracommands | |||
| do_cmakeinstall video -DENABLE_{DOCS,TOOLS,TEST{S,DATA}}=off \ | |||
| -DENABLE_NASM=on -DFORCE_HIGHBITDEPTH_DECODING=0 "${extracommands[@]}" | |||
| -DCONFIG_TUNE_VMAF=1 -DENABLE_NASM=on -DFORCE_HIGHBITDEPTH_DECODING=0 "${extracommands[@]}" | |||
There was a problem hiding this comment.
you may want to make this a conditional, based on the same conditions that libvmaf is enabled ([[ $ffmpeg != no ]] && enabled libvmaf ) since there's no guarantee that a person enabled aom will always have vmaf enabled
There was a problem hiding this comment.
VMAF for FFMPEG may not be required to enable it ....as far as I see VMAF is compiled & built after the AOM in your suite...or is there any sort of linking???.....may be -DCONFIG_TUNE_VMAF=1 is independent/inbuilt parameter of AOM.....
I will check & revert:
Well, AOM is one of the best AV1 encoders with many options/parameters to get the best results .... --tune= is one of them ...with total 7 possible options ...with --tune=psnr & --tune=ssim inbuilt .....others are:
--tune=vmaf_without_preprocessing --tune=vmaf_with_preprocessing ....there is also one of the best option i.e. --tune=butteraugli
You want to ask user an option to built AOM with vmaf in media-autobuild_suite.bat with it's corresponding code in media-suite_compile.sh? ...if that's the case then what about --tune=butteraugli?
......It's true that not everyone will use vmaf or butteraugli ...but I feel a comprehensive encoder like AOM should be built with all possible options .....screenshot of my built AOM running with --tune=vmaf_without_preprocessing
Still searching a way to include butteraugli
Description
VMAF support for AOM
Add VMAF support to aomedia so that command
--tune=vmafcan be used with standalone aom encoder.As mentioned in the AOM's readme.md
I have compiled & successfully used
--tune=vmaf_with_preprocessingwith the standalone aomenc encoder built by the script.Please note that the default VMAF model (“/usr/local/share/model/vmaf_v0.6.1.json”) will be used unless you set the following flag when running the encoder:
--vmaf-model-path=path/to/model