refactor: extract isHook to util

m4rkforks · Jul 11, 2019 · 8f57efc · 8f57efc
1 parent e901d03
commit 8f57efc
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 9 deletions.
diff --git a/src/rules/no-hooks.js b/src/rules/no-hooks.js
@@ -1,6 +1,6 @@
 'use strict';
 
-const { getDocsUrl } = require('./util');
+const { getDocsUrl, isHook } = require('./util');
 
 module.exports = {
   meta: {
@@ -24,21 +24,13 @@ module.exports = {
     },
   ],
   create(context) {
-    const testHookNames = Object.assign(Object.create(null), {
-      beforeAll: true,
-      beforeEach: true,
-      afterAll: true,
-      afterEach: true,
-    });
-
     const whitelistedHookNames = (
       context.options[0] || { allow: [] }
     ).allow.reduce((hashMap, value) => {
       hashMap[value] = true;
       return hashMap;
     }, Object.create(null));
 
-    const isHook = node => testHookNames[node.callee.name];
     const isWhitelisted = node => whitelistedHookNames[node.callee.name];
 
     return {

diff --git a/src/rules/util.js b/src/rules/util.js
@@ -99,6 +99,13 @@ const testCaseNames = Object.assign(Object.create(null), {
   xtest: true,
 });
 
+const testHookNames = Object.assign(Object.create(null), {
+  beforeAll: true,
+  beforeEach: true,
+  afterAll: true,
+  afterEach: true,
+});
+
 const getNodeName = node => {
   function joinNames(a, b) {
     return a && b ? `${a}.${b}` : null;
@@ -119,6 +126,11 @@ const getNodeName = node => {
   return null;
 };
 
+const isHook = node =>
+  node &&
+  node.type === 'CallExpression' &&
+  testHookNames[getNodeName(node.callee)];
+
 const isTestCase = node =>
   node &&
   node.type === 'CallExpression' &&
@@ -224,6 +236,7 @@ module.exports = {
   getStringValue,
   isDescribe,
   isFunction,
+  isHook,
   isTemplateLiteral,
   isTestCase,
   isString,