Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ordering when rearranging #20

Merged
merged 2 commits into from Jul 24, 2019
Merged

Fix ordering when rearranging #20

merged 2 commits into from Jul 24, 2019

Conversation

mAAdhaTTah
Copy link
Owner

Fixes #19.

@mAAdhaTTah
Copy link
Owner Author

@blastrock I'm not able to reproduce this with a test. Does the configuration in my test match your config?

@mAAdhaTTah
Copy link
Owner Author

I stand corrected... this appears to be version-bound.

@mAAdhaTTah
Copy link
Owner Author

Underlying issue appears to be V8 changing its sorting algo in the version shipped in Node 12. Blech, not sure how to produce a stable sort. For now, I'm going to remove Node 12 from the test matrix. This issue is being worked on in PrismJS itself: PrismJS/prism#1998 so I'm going to go w/ this for now and replace it with the upstream implementation when it ships.

@mAAdhaTTah
Remove stable from build matrix
a2deef6 
The sorting algo changed in Node 12, so we're going to remove it from the
test matrix for now.
@mAAdhaTTah mAAdhaTTah merged commit 199af33 into master Jul 24, 2019
@mAAdhaTTah mAAdhaTTah deleted the fix-peer-dep-order branch July 24, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependencies are in the wrong order
1 participant
@mAAdhaTTah