Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Run prettier and ESLint for staged files on pre-commit hook [PR #1 - Linting and Formatting] #62

Closed
wants to merge 3 commits into from

Conversation

tibuurcio
Copy link
Collaborator

@tibuurcio tibuurcio commented Jan 16, 2024

Instructions

  1. PR target branch should be against main
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • This is the first PR in a series of 3 where we setup Linting and Formatting and apply it for the first time. This PR adds configuration for Prettier and ESLint as well as configuration for Lint Staged and Husky in order to run both on staged files when commiting.

Testing Plan

  • Was this tested locally? If not, explain why.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@tibuurcio tibuurcio self-assigned this Jan 16, 2024
@tibuurcio tibuurcio changed the title feat: Run prettier and ESLint for staged files on pre-commit hook feat: Run prettier and ESLint for staged files on pre-commit hook [PR #1 - Linting and Formatting] Jan 16, 2024
@jared-dickman
Copy link
Collaborator

@tibuurcio can you check out this failed action, looks like when the package file is updated, we should rebuild and push the package-lock as well

1 similar comment
@jared-dickman
Copy link
Collaborator

@tibuurcio can you check out this failed action, looks like when the package file is updated, we should rebuild and push the package-lock as well

@tibuurcio
Copy link
Collaborator Author

Addressed all comments in this PR. We will keep going on the #63, #64 and #66.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants