Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a position listener #1

Conversation

christophemacabiau
Copy link

Hi,
Following the discussion on your PR, a first implementation based on your branch. Tell me what you think.

@christophemacabiau
Copy link
Author

christophemacabiau commented Sep 18, 2020

I didn't found any way to remove this fake sequence of scaleStart-scaleUpdate-scaleEnd after a pinch...

@maRci002
Copy link
Owner

I'll check it out soon, I don't know why didn't notify github about this PR.

@maRci002
Copy link
Owner

I think this feature would be too much for this issue (gesture race implementation was overkill too). I am going to remove the WIP flag from the title soon (I still need to recheck the code and add some docs) and when it is merged into master then you can create a direct PR to flutter_map repository.

Anyway that number 5 seems magic number for me. This feature is a special request which is good but maybe there is a cleaner solution and more generics one which would handle other cases, I know currently this solves you problem and thats good. Don't forget you can keep and test a local copy of the project and maintain it. Forinstance I have a lot of private code which wasn't allowed to push into flutter_map's private repo and in the very close future I think I have to implement something like this so I can help if it is allowed.

@maRci002 maRci002 closed this Sep 29, 2020
@christophemacabiau
Copy link
Author

Sorry for the delay. Thanks for your answer.
The flutter_map does not seem to be very active... I will use my fork for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants