Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#347): change inputRef to ref to prevent runtime error #374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(#347): change inputRef to ref to prevent runtime error #374

wants to merge 1 commit into from

Conversation

enricomad
Copy link

@enricomad enricomad commented Aug 27, 2021 •
edited

Motivation

When editing (focusing) an attribute value, VariableEditor causes react_devtools_backend to throw a runtime error due to usage of unrecognized attribute inputRef (instead of ref) in AutosizeTextarea component.

Warning: React does not recognize the `inputRef` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `inputref` instead. If you accidentally passed it from a parent component, remove it from the DOM element.

AutosizeTextarea docs
related issue: #347

@enricomad enricomad marked this pull request as draft August 27, 2021 13:17
@enricomad enricomad marked this pull request as ready for review August 27, 2021 13:32
@enricomad enricomad changed the title fix(#347): change inputRef to ref to prevent runtime error fix(#347): change inputRef to ref to prevent runtime warning Aug 27, 2021
@enricomad enricomad marked this pull request as draft August 27, 2021 15:37
@enricomad enricomad marked this pull request as ready for review August 27, 2021 15:42
@enricomad enricomad changed the title fix(#347): change inputRef to ref to prevent runtime warning fix(#347): change inputRef to ref to prevent runtime error Aug 27, 2021
@enricomad enricomad mentioned this pull request Dec 7, 2021
Open
@dranitski
Copy link

upvote this fix

@dranitski dranitski mentioned this pull request Dec 13, 2021
Open
enricomad referenced this pull request in enricomad/react-json-view Jan 27, 2022
@enricomad
fix(mac-s-g#347): change inputRef to ref to prevent runtime error
1f961e9
@damianpugliese
Copy link

Some news for this Issue? The library is the best in my opinion but with this Issue I can't use it

@AhmedBHameed
Copy link

AhmedBHameed commented Jun 11, 2022 •
edited

@mac-s-g
Can you consider this PR as a fix?
Appreciate your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danifilipers-git danifilipers-git danifilipers-git approved these changes

@damianpugliese damianpugliese damianpugliese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@enricomad @dranitski @damianpugliese @AhmedBHameed @danifilipers-git