Moving minikube hyperkit changes upstream

[sharifelgamal]

Author: Thomas Stromberg <tstromberg@google.com>
Date:   Thu Aug 22 11:41:41 2019 -0700

    Remove broken default disk size test that didn't make sense

commit a817bffab1752e8956f68a88cf2548f2dc2932e9
Author: Sharif Elgamal <selgamal@google.com>
Date:   Mon Aug 12 14:42:11 2019 -0700

    Remove all minikube dependencies from drivers (#4933)
    
    * Remove all minikube dependencies in driver code
    
    * removing all default config
    
    * okay we need some defaults
    
    * code comments
    
    * hyperkit builds now
    
    * sleep for an appropriate amount of time
    
    * remove constant in favor of string
    
    * try goproxy for travis
    
    * try goproxy for travis
    
    * try goproxy for travis
    
    * let's not try goproxy for now
    
    * let's try goproxy once again
    
    * maybe use the correct url for the proxy
    
    * fix go mod

commit 99ac1a81e764097480301aa1d0b6308dc80e6e1e
Author: Medya Gh <medya@google.com>
Date:   Thu Jul 4 16:31:07 2019 -0700

    moving command runner to its own package

commit 2aac268ba64d7fbf53e27ad58927fa7899f11132
Merge: cdf895f81 4812761f0
Author: Medya Ghazizadeh <medyagh@users.noreply.github.com>
Date:   Mon Jul 1 14:38:30 2019 -0700

    Merge pull request #4593 from josedonizetti/add-hyperkit-version
    
    Add version to hyperkit driver

commit 449c8781e10843eabd88a2296f4614bd77f9eef6
Merge: 037e9a5d5 0305c9d0f
Author: Medya Ghazizadeh <medyagh@users.noreply.github.com>
Date:   Sun Jun 30 15:17:28 2019 -0700

    Merge pull request #4595 from blueelvis/memory-size-sanity-check
    
    Added validation for start memory size

commit 4812761f05b855f3d3702eaa3ceffacaede54479
Author: Jose Donizetti <jdbjunior@gmail.com>
Date:   Sat Jun 29 09:32:21 2019 -0300

    Add gitCommitID to hyperkit version

commit 931a0a557b19c2676caa9f64e9f564760c9f17d1
Author: josedonizetti <jdbjunior@gmail.com>
Date:   Tue Jun 25 14:09:44 2019 -0300

    Add hyperkit version

commit 7fe2247692ea0b7e4bd6878b6b612568d0fb9cd9
Author: Jose Donizetti <jdbjunior@gmail.com>
Date:   Fri Jun 28 20:36:36 2019 -0300

    Improve hyperkit vm stop

commit 6222e74267727ade038b404f104932f0bc39703a
Author: Jose Donizetti <jdbjunior@gmail.com>
Date:   Fri Jun 28 17:44:15 2019 -0300

    Add hyperkit doc

commit 380883dee323e54e064547a421b0141d4e91170f
Author: Jituri, Pranav <blueelvisrocks@gmail.com>
Date:   Wed Jun 26 01:45:12 2019 +0530

    Fix failing Hyperkit test

commit c7bf1ce7cdad3ab41143248191bf367fa03518b8
Author: Medya Gh <medya@google.com>
Date:   Mon Jun 24 14:39:21 2019 -0700

    type check for drivers

commit 0e633533c228d257e5d42dd8e0af254afecd4c68
Author: josedonizetti <jdbjunior@gmail.com>
Date:   Thu May 30 17:24:28 2019 -0300

    Refactor: improve readability drivers.Restart

commit 88f34bd0e3d659b24589c899c57957131b8e5110
Author: tstromberg <tstromberg@google.com>
Date:   Wed May 15 10:25:34 2019 -0700

    Pass up better error messages

commit f8c5fad43716bf8e6025f6616edab3efa9d2acba
Author: tstromberg <tstromberg@google.com>
Date:   Tue May 14 09:05:34 2019 -0700

    Mark as darwin only, to match network.go

commit 6e693d22ee85d1ab666b88fb0fa00186fdb3a74a
Author: Thomas Stromberg <tstromberg@google.com>
Date:   Mon May 13 21:43:52 2019 -0700

    lint-a-geddon is here

commit 9a9f9edf5fb2e199c4d6bbce0a9d7ed4cbdb1a05
Author: tstromberg <tstromberg@google.com>
Date:   Mon May 13 18:31:55 2019 -0700

    First pass at lint-ageddon

commit 88c45bf5b25ab70184d3cac5d602715d6a61fa14
Merge: 460ef571e 20b9cfd0f
Author: Thomas Strömberg <tstromberg@google.com>
Date:   Thu Mar 21 11:34:45 2019 -0700

    Merge branch 'master' into lint

commit edf46f003f25ed87cf8f75690f9af3bb207795ca
Author: Anders F Björklund <anders.f.bjorklund@gmail.com>
Date:   Sat Mar 16 14:12:18 2019 +0100

    Document all exported functions outside minikube

commit 6d96a67456bbcc2317d668ffee57e486af3ab6e3
Author: Anders F Björklund <anders.f.bjorklund@gmail.com>
Date:   Sun Mar 10 14:33:24 2019 +0100

    Run go vet on all code, not just pkg and cmd

commit 46640cef686d2889cdca798fbe4b0772fef24891
Author: Anders F Björklund <anders.f.bjorklund@gmail.com>
Date:   Sat Mar 2 22:02:56 2019 +0100

    Address all lint except undocumented and stutter
    
    These two lint warnings still remain, after the cleanup:
    "exported ... should have comment or be unexported"
    
    "type name will be used as foo.FooBar by other packages,
     and that stutters; consider calling this Bar"

commit 07fc64fbe169ea4e13bd4730ef66769e93494c1e
Author: Thomas Stromberg <tstromberg@google.com>
Date:   Thu Feb 14 20:12:34 2019 -0800

    Warnf -> Debugf so that it doesn't interfere with output

commit 7dd7e5417dfb75b8a6e469cf297809795e0b0bd6
Author: Thomas Stromberg <tstromberg@google.com>
Date:   Thu Feb 14 14:43:22 2019 -0800

    glog, not golog

commit 531e6b0f726da2db061394eaaa21e99439f4078b
Author: Thomas Stromberg <tstromberg@google.com>
Date:   Thu Feb 14 14:40:32 2019 -0800

    Use h.SetLogger

commit 0c8a452e977d21c5216b4debbfc4d7790291c188
Author: Thomas Stromberg <tstromberg@google.com>
Date:   Thu Feb 14 14:40:16 2019 -0800

    lowercase error messages

commit 5c1a72f428daddda30550e7d75aa575aaa60635e
Author: Thomas Stromberg <tstromberg@google.com>
Date:   Thu Feb 14 10:14:41 2019 -0800

    Switch Infof statements to Debugf/Warningf, as they go to stderr

commit 473f5983cb8b7e61a15290fc12bbbf87432708fe
Author: Thomas Stromberg <tstromberg@google.com>
Date:   Wed Feb 13 13:36:45 2019 -0800

    Allow driver name to be com.docker.hyper, as seen in integration testing

commit 4b875ddd7f5f9577fd9baa38586072ea3ff75bca
Author: Thomas Stromberg <tstromberg@google.com>
Date:   Wed Feb 13 13:35:28 2019 -0800

    Run goimports

commit 2045dc9ba419592d4cd70676b13ecb7573ee1c68
Author: Thomas Stromberg <tstromberg@google.com>
Date:   Wed Feb 13 13:35:08 2019 -0800

    Lint cleanup

commit 888978c3a9aafc0325de03305b6f30a333a2d651
Author: Thomas Stromberg <tstromberg@google.com>
Date:   Tue Feb 12 13:58:18 2019 -0800

    Improve VM re-use reliability: detect crashing and/or badly installed hyperkit

commit f346e5628b12a503100f58af35cd2d7fb8093235
Author: Thomas Stromberg <tstromberg@google.com>
Date:   Tue Feb 12 13:57:02 2019 -0800

    Add logging around the DHCP discovery process

commit d57d8d1a1e9b290c6ee17030171e6d679a6b7993
Author: Thomas Stromberg <tstromberg@google.com>
Date:   Fri Feb 8 13:58:02 2019 -0800

    Fix broken tests: hyperkit driver format mismatch, console spacing mismatch

commit 17c0244cf7846c47413b4603a3b39ec6c311dbff
Author: balopat <balintp@google.com>
Date:   Mon Jan 28 17:28:57 2019 -0800

    reverting unnecessary change

commit 5af2f1eafc7a5d00238d05637682bf4264343497
Author: balopat <balintp@google.com>
Date:   Mon Jan 28 13:47:24 2019 -0800

    formatting / removed extra comment

commit f70e6a03858ac33a7e4168680f8c38fdb1ad8b92
Author: balopat <balintp@google.com>
Date:   Mon Jan 28 13:42:43 2019 -0800

    fixing review remarks

commit 933356e4776f18a508a1c9416d1569438f4e7983
Author: balopat <balintp@google.com>
Date:   Fri Jan 25 17:20:57 2019 -0800

    lint

commit 9b97a85a8fd82f1c7e1d4b9a8cacc97a80d15ce8
Author: balopat <balintp@google.com>
Date:   Fri Jan 25 16:26:28 2019 -0800

    fix stale hyperkit.pid making minikube start hang

commit 0687fea66aac9b8993a3b86c4a57b608bbf6eb96
Author: bpopovschi <zyqsempai@mail.ru>
Date:   Mon Jan 14 16:41:41 2019 +0200

    Added defaultDiskSize setup to hyperkit driver
    
    fmt fix

commit 3706b3b8ac7ac670fa5dc80b93912957fd9cf696
Author: Thomas Stromberg <tstromberg@google.com>
Date:   Fri Sep 28 16:48:37 2018 -0700

    Fix dangling format issues.

commit 055c8002b1af170205621020db74840eb5e3cc56
Author: Thomas Stromberg <tstromberg@google.com>
Date:   Fri Sep 28 16:05:27 2018 -0700

    Replace %s format directives with %v for errors.
    
    Previously we were mixed between the two forms. This commit picks %v,
    which is consistent with the Kubernetes code base. They both effectively
    do the same thing in this case, though %v works with any object, and %s
    only with string objects.

commit 232080ae0cbcf9cb9a388eb76cc11cf6884e19c0
Author: dlorenc <dlorenc@google.com>
Date:   Tue Jul 24 12:51:53 2018 -0700

    Remove some more vendored k8s.

commit ee73cbde6bfdbdf2af9dbaf2a650b511f7af83d7
Author: seborama <seb.d.albion@outlook.com>
Date:   Thu May 24 22:59:54 2018 +0100

    Added hyperkit options for enterprise VPN support
    
    The purpose of these changes is to enhance Hyperkit support from the
    minikube command line for better integration with enterprise networks
    behind a VPN.
    
    uuid: Provide VM UUID to restore MAC address (only supported with
          Hyperkit driver).
    vpnkitSock: Location of the VPNKit socket used for networking. If empty,
                disables Hyperkit VPNKitSock, if 'auto' uses Docker for Mac
                VPNKit connection, otherwise uses the specified VSock."
    vsockPorts: List of guest VSock ports that should be exposed as sockets
                on the host (Only supported on with hyperkit now).
    
    Note:
    tests pass but file:
    `vendor/github.com/google/certificate-transparency/go/x509/root_darwin.go`
    has to be edited to correct an issue - not committed since this is in
    the vendor directory.

commit cebd704bd753bda5e0ae0709ee2fb566a9e578d3
Author: basp <b.passon@first8.nl>
Date:   Thu Jan 11 14:32:02 2018 +0100

    Issue #2416: Added UUID to hyperkit driver section in minikube configuration to be able to regenerate the same mac address for the machine after restarts to give DHCP a change of assigning the previously used IP address.

commit bc55b8b8beb42609a195a62477a04086b71250d6
Author: Hugues Alary <hugues@betabrand.com>
Date:   Tue Jan 2 14:25:30 2018 -0800

    Cleanup NFS Exports after stop and delete

commit 59274b22da44b1c9e5fee989c19e848feb4e02d9
Author: dlorenc <dlorenc@google.com>
Date:   Tue Jan 2 13:32:47 2018 -0800

    Code review feedback.

commit e3f3727b4dd04cedaff7ff7dbe13db38fa3f2e12
Author: dlorenc <dlorenc@google.com>
Date:   Wed Dec 27 13:00:07 2017 -0800

    Move GetNetAddr.
    
    The build constraints in vmnet.go cause issues.

commit 7d9413ccd1c192da1aa42c8eba8bde232a434be6
Author: Mohit Gupta <mohit.gupta@live.ca>
Date:   Wed Dec 13 16:37:00 2017 -0800

    remove the hyperkit prefix so we can move this to other drivers as well with time and fix vendoring issue

commit e1903b7423fca1464a9447dade4d97bb341148cb
Author: Mohit Gupta <mohit.gupta@live.ca>
Date:   Tue Dec 12 09:54:58 2017 -0800

    support NFS sharing with the hyperkit driver

commit fdf906cf3b1a6bfc07700075d54b069be317739a
Author: dlorenc <lorenc.d@gmail.com>
Date:   Fri Nov 24 09:38:19 2017 -0800

    Add an error message when running hyperkit without permissions.

commit bc20281f1ee482f294d742120f1b8007531ab171
Author: dlorenc <lorenc.d@gmail.com>
Date:   Tue Nov 14 09:15:02 2017 -0800

    Update hyperkit go driver.

commit a19f90fd911de0012f705438c5841ebdb7c84128
Author: Matt Rickard <mrick@google.com>
Date:   Thu Oct 19 16:23:36 2017 -0400

    import erorr

commit 02f0d41c1d7753ed9e35db93f8808c1fa238a5f1
Author: Matt Rickard <mrick@google.com>
Date:   Thu Oct 19 16:07:38 2017 -0400

    Split out hyperkit into CGO needed stub
    
    This allows us to use the hyperkit Driver struct in minikube, without
    needing CGO_ENABLED=1.  For the hyperkit driver binary, the
    CGO_ENABLED=1 function will work.

commit ebbc34d2ba342004fea245db71eee480fcafa8cf
Author: Matt Rickard <mrick@google.com>
Date:   Sun Sep 10 14:59:11 2017 -0700

    Move drivers to pkg/drivers, share utils
    
    Share most of the disk image setup between hyperkit and kvm drivers.
    Move and remove a lot of shared configuration between all the in-tree
    drivers: kvm, hyperkit, none.

commit e3d239929b0eeac767b26cac82bbe08a111837e6
Author: dlorenc <lorenc.d@gmail.com>
Date:   Mon Aug 14 21:02:55 2017 -0700

    Jenkins/Makefile targets.

commit 28f9d5dc1ad9a8bf07940a7f8ff149effd2277bf
Author: dlorenc <dlorenc@google.com>
Date:   Mon May 22 13:19:25 2017 -0700

    Initial hyperkit driver implementation.

[tstromberg]

Looks good. Could you test and confirm that this driver works for bothdocker-machine and minikube?

[sharifelgamal]

I've verified that it works with minikube and docker-machine is documented as not working with hyperkit.