selfupdate: Prints number of outdated ports after updating ports tree

[thelastlin]

Hi,

Here is a tiny suggestion about user interface.
People may want to know how many ports can be upgraded after the ports tree has been updated by port selfupdate.

This patch prints about numbers of outdated ports like this:

# port selfupdate
--->  Updating MacPorts base sources using rsync
MacPorts base version 2.8.1 installed,
MacPorts base version 2.8.1 downloaded.
--->  Updating the ports tree
--->  MacPorts base is already the latest version

The ports tree has been updated. To upgrade your installed ports, you should run
  port upgrade outdated

2 ports are outdated. Run 'port outdated' to see them.

and when no installed ports are outdated will look like this:

# port selfupdate
--->  Updating MacPorts base sources using rsync
MacPorts base version 2.8.1 installed,
MacPorts base version 2.8.1 downloaded.
--->  Updating the ports tree
--->  MacPorts base is already the latest version

The ports tree has been updated. To upgrade your installed ports, you should run
  port upgrade outdated

All installed ports are up to date.

[jmroot]

Thanks for the contribution. This would close https://trac.macports.org/ticket/33820.

[thelastlin]

Does needed_portindex actually required if the port base has been updated with no --no-sync given?

Seems that we can just check base_updated at here to print messages for rerun port selfupdate.

[raimue]

Moving this message to port.tcl looks good to me, as it is up to the client to restart the selfupdate (or ask the user to do so).

The check for --no-sync is the same as inside the macports1.0 API and that seems redundant. The needed_portindex would not be set otherwise.

But your change lost the condition on base_updated here.

As a side note, the macports1.0 API change is not backwards compatible, so we should only ship this with the next 2.x.0 release.

[thelastlin]

The check for --no-sync is the same as inside the macports1.0 API and that seems redundant. The needed_portindex would not be set otherwise.

Checking for --no-sync might be required for messages about restarting the selfupdate at here.
It can be returned by macports::selfupdate, but I'm not sure if it's necessary since there are some similar checks in port.tcl.

But your change lost the condition on base_updated here.

The check for base_updated might not be required at here, asportindex may not running in some cases:

macports-base/src/macports1.0/macports.tcl

Line 3034 in 87a8c78

set needs_portindex false

[raimue]

This is when the ports tree was downloaded, but the Portfiles use new features of base, so they cannot be parsed with the old version. The message being printed only makes sense when base was updated.