Remove "Creating launchd control script" message #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be worth keeping at least a ui_debug message to indicate that this is happening? |
Remove "Creating launchd control script" message from the user-visible terminal output and print it only in the log and debug output. This message or one of its prior wordings has been present ever since the startup item code was originally added in 3ffdaf3 in 2005. I presume the purpose of this message was to inform the user that a startup item existed for this port. It no longer accomplishes that purpose because it only appears during the destroot phase which most users will not see because they install pre-built archives instead of building from source. Meanwhile a better message in the form of notes that display at the end of installation, regardless of whether it was from source or via pre-built archive, was added in 6faf3f8 in 2018. Originally, the startup item was created at the end of the destroot phase, so users would first see the "Staging into destroot" message, followed by a delay as staging occurred, followed by the "Creating launchd control script" message, followed almost immediately by the install phase messages. In 6f7ed40 in 2020 it was changed so that startup items would be created at the beginning of the destroot phase. This made the output more confusing: now, "Staging into destroot" was followed immediately by "Creating launchd control script", which would then remain until staging had completed, giving the erroneous impression that staging completed instantly while creating the control script took a long time. Nothing else in the destroot phase gets the special privilege of printing an extra line to the terminal; there's no reason why creating the launchd control script should do so.
|
I made that change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This message or one of its prior wordings has been present ever since the startup item code was originally added in 3ffdaf3 in 2005.
I presume the purpose of this message was to inform the user that a startup item existed for this port. It no longer accomplishes that purpose because it only appears during the destroot phase which most users will not see because they install pre-built archives instead of building from source. Meanwhile a better message in the form of notes that display at the end of installation, regardless of whether it was from source or via pre-built archive, was added in 6faf3f8 in 2018.
Originally, the startup item was created at the end of the destroot phase, so users would first see the "Staging into destroot" message, followed by a delay as staging occurred, followed by the "Creating launchd control script" message, followed almost immediately by the install phase messages. In 6f7ed40 in 2020 it was changed so that startup items would be created at the beginning of the destroot phase. This made the output more confusing: now, "Staging into destroot" was followed immediately by "Creating launchd control script", which would then remain until staging had completed, giving the erroneous impression that staging completed instantly while creating the control script took a long time.
Nothing else in the destroot phase gets the special privilege of printing an extra line to the terminal; there's no reason why creating the launchd control script should do so.
Thus, remove the "Creating launchd control script" message entirely.