Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deleting distfiles if distfiles is a symlink #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryandesign
Copy link
Contributor

When I originally prevented deletions if distfiles was a symlink in f151333 I was considering replacing the distfiles directory on each worker with a symlink to the master distfiles volume mounted over AFP/SMB to save disk space on the workers. I didn't end up trying that, but on the Apple Silicon workers I have now made distfiles a symlink to a shared directory where I do want deletions to occur, so I've changed the condition so now deletions can occur unless ports.tar.gz exists; that would only exist on the master. I added a slash to the end of the distfiles path since otherwise find won't descend into the symlinks.

When I originally prevented deletions if distfiles was a symlink in
f151333 I was considering replacing the distfiles directory on each
worker with a symlink to the master distfiles volume mounted over
AFP/SMB to save disk space on the workers. I didn't end up trying that,
but on the Apple Silicon workers I have now made distfiles a symlink to
a shared directory where I do want deletions to occur, so I've changed
the condition so now deletions can occur unless ports.tar.gz exists;
that would only exist on the master. I added a slash to the end of the
distfiles path since otherwise find won't descend into the symlinks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant