Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add didyoumean #31

Merged
merged 4 commits into from Oct 7, 2019
Merged

Add didyoumean #31

merged 4 commits into from Oct 7, 2019

Conversation

LapinoLapidus
Copy link
Contributor

Description

Added "Did you mean" functionality using didyoumean.js as specified in #30
Fixes #30

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@welcome
Copy link

welcome bot commented Oct 6, 2019

Thanks for opening this pull request! Please check out our contributing guidelines.

@jamesgeorge007 jamesgeorge007 self-requested a review October 6, 2019 16:36
@jamesgeorge007 jamesgeorge007 added enhancement New feature or request Hacktoberfest labels Oct 6, 2019
@jamesgeorge007 jamesgeorge007 added this to In progress in Roadmap via automation Oct 6, 2019
jamesgeorge007
jamesgeorge007 requested changes Oct 6, 2019
View reviewed changes
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow this approach as here

Roadmap automation moved this from In progress to Needs review Oct 6, 2019
@jamesgeorge007 jamesgeorge007 self-requested a review October 7, 2019 04:11
@jamesgeorge007 jamesgeorge007 added this to the v1.2.0 milestone Oct 7, 2019
Roadmap automation moved this from Needs review to Reviewer approved Oct 7, 2019
jamesgeorge007
jamesgeorge007 approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jamesgeorge007 jamesgeorge007 merged commit d10bc1c into madlabsinc:next Oct 7, 2019
Roadmap automation moved this from Reviewer approved to Done Oct 7, 2019
@welcome
Copy link

welcome bot commented Oct 7, 2019

congrats
Congrats on your very first contribution 👏 Looking forward to having more from your side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgeorge007 jamesgeorge007 jamesgeorge007 approved these changes

Assignees

@LapinoLapidus LapinoLapidus

Labels
enhancement New feature or request Hacktoberfest
Projects
Roadmap
  
Done
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Suggest matching commands if the user makes a typo
2 participants
@LapinoLapidus @jamesgeorge007