This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
Ubuntu doesn't use ia32-libs from 14.04 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to jump through quite a few hoops to get the tests to pass my >= comparison and I am not sure I like the inline template and string to integer conversion I had to do. Puppet documentation says that comparing an integer and a float automatically converts/truncates the float to an integer which works fine for my purpose but I guess relying on such side effects is not good practice and the current approach is more explicit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu from 14.04 doesn't use ia32-libs. Use libc6-i386, lib32stdc++6, lib32gcc1, lib32ncurses5, and lib32z1 instead.
Instead of listing each Ubuntu release by name apply this rule to releases >= 14.04.