Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading the request library to remove deprecation warning. #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrading the request library to remove deprecation warning. #40

wants to merge 1 commit into from

Conversation

rhberro
Copy link

@rhberro rhberro commented Jan 25, 2018 •
edited

This pull request will remove the deprecation warning that we get from the request library. As you can see here the deprecation warning was removed from the latest version.

screen shot 2018-01-24 at 22 59 59

Also, added a package-lock.json file.

@quaelin
Copy link

quaelin commented Oct 9, 2018

Hey @mafintosh, we use this module (sqs) but it's triggering a bunch of security warnings for us and this PR would fix them, if it was merged and published. (Actually, the request module is now up to 2.88.0, so ideally you'd update to use that.) Any chance you'd be able to publish a new module so that stops triggering npm security warnings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rhberro @quaelin