Faster state machine #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafintosh
force-pushed
the
faster-state-machine
branch
from
99feb99
to
6893eb2
Compare
gmaclennan
added a commit
to digidem/multi-core-indexer
that referenced
this pull request
Jul 6, 2023
We don't yet properly test for back pressure. This was only covered before because a slow state machine in streamx was resulting in backpressure here, but the fixes in mafintosh/streamx#77 resulted in no backpressure, so this line became uncovered by tests
gmaclennan
added a commit
to digidem/multi-core-indexer
that referenced
this pull request
Jul 6, 2023
We don't yet properly test for back pressure. This was only covered before because a slow state machine in streamx was resulting in backpressure here, but the fixes in mafintosh/streamx#77 resulted in no backpressure, so this line became uncovered by tests
gmaclennan
added a commit
to digidem/multi-core-indexer
that referenced
this pull request
Jul 6, 2023
* update deps * chore: update deps not in merge commit * fix: Ignore missing coverage for backpressure We don't yet properly test for back pressure. This was only covered before because a slow state machine in streamx was resulting in backpressure here, but the fixes in mafintosh/streamx#77 resulted in no backpressure, so this line became uncovered by tests * fix: fix for random-access-memory@6 --------- Co-authored-by: Gregor MacLennan <gmaclennan@digital-democracy.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some live lock bugs that happen if you don't call the read cb for a long time, which "live streams" tend to not do