Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use newListener event instead of overriding EventEmitter#on #79

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Use newListener event instead of overriding EventEmitter#on #79

merged 2 commits into from
Dec 8, 2023

Conversation

kasperisager
Copy link
Contributor

This ensures that listeners added using other methods like addListener() and prependListener() also cause the stream to flow.

@kasperisager
Copy link
Contributor Author

@mafintosh This is ready for review.

mafintosh
mafintosh reviewed Sep 11, 2023
View reviewed changes
index.js Outdated Show resolved Hide resolved
@mafintosh mafintosh merged commit e41329b into mafintosh:master Dec 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafintosh mafintosh Awaiting requested review from mafintosh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kasperisager @mafintosh