test using symlinks duh

mafintosh · Jun 17, 2023 · 41af412 · 41af412
1 parent 71d681b
commit 41af412
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/index.js b/index.js
@@ -156,7 +156,6 @@ exports.extract = function extract (cwd, opts) {
     header.name = normalize(header.name)
 
     const name = path.join(cwd, path.join('/', header.name))
-    console.log(header, name)
 
     if (ignore(name, header)) {
       stream.resume()
@@ -308,14 +307,11 @@ exports.extract = function extract (cwd, opts) {
 }
 
 function validate (fs, name, root, cb) {
-  console.log('validate', name, root)
   if (name === root) return cb(null, true)
   fs.lstat(name, function (err, st) {
     if (err && err.code === 'ENOENT') return validate(fs, path.join(name, '..'), root, cb)
     else if (err) return cb(err)
-    console.log('lookup', name)
-    if (st.isDirectory()) return cb(null, true)
-    cb(null, false)
+    cb(null, st.isDirectory())
   })
 }
 

diff --git a/test/index.js b/test/index.js
@@ -293,7 +293,13 @@ test('not finalizing the pack', function (t) {
   }
 })
 
-test.solo('do not extract invalid tar', function (t) {
+test('do not extract invalid tar', function (t) {
+  if (win32) { // no symlink support on win32 currently. TODO: test if this can be enabled somehow
+    t.plan(1)
+    t.ok(true)
+    return
+  }
+
   t.plan(2)
 
   const a = path.join(__dirname, 'fixtures', 'invalid.tar')