fix race condition involving engine.destroy() and ready event
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'ready' event sets up an interval timer that is cleared in `destroy()`. However, in some situations, it is possible to for the interval to be created after `destroy()` has run, resulting in an interval timer that is never cleared, and thus an app that does not exit when it is supposed to. This change fixes the issue and adds a test for it. Refs: mafintosh#198
|
@mafintosh Sorry for the ping, but any chance this or some other equivalent change can get in soon and be released? This is a race condition that is sometimes triggered in CITGM. |
|
It’s on my todo for tmw now |
|
/re-ping! We're down to just three errors in CITGM on the upcoming LTS branch and this is one of them. Would love to get it fixed soon! |
|
Thanks @Trott ! I didn't realise you actually sent a PR and not just the issue until I pushed a similar fix. Anyways should be fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'ready' event sets up an interval timer that is cleared in
destroy(). However, in some situations, it is possible to for theinterval to be created after
destroy()has run, resulting in aninterval timer that is never cleared, and thus an app that does not
exit when it is supposed to. This change fixes the issue and adds a
test for it.
Refs: #198