Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xy] Some improvements on multi project #5063

Merged
merged 3 commits into from
May 14, 2024

Conversation

wangxiaoyou1993
Copy link
Member

@wangxiaoyou1993 wangxiaoyou1993 commented May 14, 2024

Description

  • Remove unnecessary project model initialization
  • Check user project setting with env var instead of sub project's project setting. Env var is ENABLE_USER_PROJECTS
  • Remove duplicate feature flag check

How Has This Been Tested?

  • Tested locally

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

cc:

@wangxiaoyou1993 wangxiaoyou1993 added the enhancement Polish or UX improvements label May 14, 2024
@wangxiaoyou1993 wangxiaoyou1993 merged commit c3067a0 into master May 14, 2024
11 checks passed
@wangxiaoyou1993 wangxiaoyou1993 deleted the xiaoyou/fix-multi-project2 branch May 14, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Polish or UX improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant