Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nx Integration Workflow not waiting for called workflow to complete #74

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

adamzero1
Copy link
Contributor

Description (*)

When a PR is submited, this repo calls a workflow in the actions repo. The workflow in this repo does not wait for the called repo to complete.
image
Here we can see "Calling Nx Integration Tests" doesn't care about the results of the tests ran from the matrix.

Related Pull Requests

https://github.com/mage-os/mageos-magento2/actions/runs/7101858336?pr=68

Fixed Issues (if relevant)

With this in place we should see the following (please note these screenshot were taken from another repo as I can't mimic how this will work until this is in the default branch)

If the matrix jobs complete successfully
image

If the matrix jobs fail (i.e integration tests fail)
image

Manual testing scenarios (*)

N/A

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@adamzero1 adamzero1 requested a review from a team as a code owner December 12, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant