Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add go install directions for Go 1.16+ #360

Closed
wants to merge 1 commit into from

Conversation

sheldonhull
Copy link

  • Provide go install command as option for those running Go 1.16+.

docs

- Provide `go install` command as option for those running Go 1.16+.

[docs](https://golang.org/ref/mod#go-install)
@natefinch
Copy link
Member

So the only problem with that is that it doesn't build in the mage version info.

ideally, people wouldn't install that way, because it makes it harder to debug problems without that build info.

@alock
Copy link

alock commented Aug 27, 2021

Would you have any interest in adding something like https://github.com/goreleaser/goreleaser to enable installs? This should be able to keep versions and maybe meet a similar desire to go install.

@sheldonhull
Copy link
Author

@alock goreleaser is just a tool for building and pushing various distribution methods. It provides a nice way to automate different distribution methods like hombrew, curl single line install scripts, docker images, and stuff like that. Not really solving the same issue I was trying to provide by just adding the native go install technique.

@natefinch the version metadata could be set to the git commit sha when not provided by a semver version. Would that be acceptable? Go install just provides a really low overhead cross platform way to install this so figured would be worth trying.

@arschles
Copy link
Contributor

arschles commented Sep 23, 2021

ideally, people wouldn't install that way, because it makes it harder to debug problems without that build info.

+1. I think mage would be better served by having homebrew/apt/$PACKAGE_MANAGER packages and including install instructions for those, instead of asking people to install via the go tool

Edit: one idea that would be fairly easy to start with - provide install instructions for curling the binary from the GH releases page down to your machine. I haven't seen those on the website (maybe I missed them though)

@sheldonhull
Copy link
Author

We can look at that. Makes sense to have a curl install option. However, considering go install solves cross platform setup for Go devs without any need to worry about handling packaging/release of binaries, I thought it was worth considering. I bootstrap all my dev environments with a range of go install cli tools.

I guess this can be closed out.
New work for Scoop for windows, brew for mac, and curl for linux perhaps in the future. 👍

@arschles
Copy link
Contributor

arschles commented Oct 1, 2021

@sheldonhull fair enough. at some point in the future, brew install mage would be 🤯

@natefinch
Copy link
Member

brew install is probably good to have

@mirogta
Copy link
Member

mirogta commented Oct 2, 2021

brew install is probably good to have

@natefinch it already exists - see here and here - but I can't see who owns it and how does it get updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants