[eslint] Require trailing commas where useful #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pykettk
approved these changes
Feb 7, 2022
m2-community-project
bot
moved this from Ready for Review
to Reviewer Approved
in Pull Request Progress
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
fredden
changed the title
m2-community-project
bot
moved this from Reviewer Approved
to Ready for Review
in Pull Request Progress
m2-community-project
bot
added
Progress: ready for review
and removed
Progress: approved
labels
markshust
approved these changes
Dec 19, 2023
m2-community-project
bot
moved this from Ready for Review
to Reviewer Approved
in Pull Request Progress
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small part of #347 as suggested in #347 (comment).
https://eslint.org/docs/rules/comma-dangle
Including a trailing comma when the closing
]or}is on a different line means that it's easier to see what's changed when reviewing code. Adding a new item to an array or property to an object means that only the new line needs to be added, and no existing lines need to be modified; removing an item or property means that only that line needs to be removed with others remaining unchanged.