Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only auto-fix $this to $block when safe to do #413

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

fredden
Copy link
Member

@fredden fredden commented Jul 7, 2022

Fixes #407

@fredden
Copy link
Member Author

fredden commented Oct 14, 2022

@svera is there something I can do to help get this merged in?

@sinhaparul
Copy link
Contributor

@magento import PR to magento-commerce/magento-coding-standard repository

@m2-github-services
Copy link
Contributor

@sinhaparul the Pull Request is successfully imported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Pull Request Progress
  
Reviewer Approved
Development

Successfully merging this pull request may close these issues.

Replacing $this with $block in templates is not universally safe / correct
4 participants